url encoding changes #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suhase
approved these changes
Jan 23, 2026
There was a problem hiding this comment.
Pull request overview
Updates getReportUrl() to return a URL with properly encoded query parameters (notably [/]), and adds coverage to validate that behavior.
Changes:
- Reworked
PerfectoReportiumClient#getReportUrl()to rebuild the URL usingURI+URIBuilderand (re)encode query parameters. - Added a unit test asserting correct encoding of query parameters in the report URL.
- Updated an existing test assertion around relative report URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| reportium-java/src/main/java/com/perfecto/reportium/client/PerfectoReportiumClient.java | Rebuilds report URL via URIBuilder to apply URL encoding to query parameters. |
| reportium-java/src/test/java/com/perfecto/reportium/client/PerfectoReportiumClientTest.java | Adds test for encoded query params and adjusts an existing expected report URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reportium-java/src/test/java/com/perfecto/reportium/client/PerfectoReportiumClientTest.java
Show resolved
Hide resolved
Comment on lines
+229
to
+247
| URIBuilder uriBuilder = new URIBuilder() | ||
| .setScheme(originalUri.getScheme()) | ||
| .setHost(originalUri.getHost()) | ||
| .setPort(originalUri.getPort()) | ||
| .setPath(originalUri.getPath()); | ||
|
|
||
| // Parse and add query parameters - URIBuilder will encode them | ||
| if (originalUri.getQuery() != null) { | ||
| String[] pairs = originalUri.getQuery().split("&"); | ||
| for (String pair : pairs) { | ||
| String[] keyValue = pair.split("=", 2); | ||
| if (keyValue.length == 2) { | ||
| uriBuilder.addParameter(keyValue[0], keyValue[1]); | ||
| } else { | ||
| uriBuilder.addParameter(keyValue[0], ""); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
getQuery() returns the decoded query string, so splitting on '&' can break when a parameter value contains an encoded ampersand (%26) (it will be decoded to '&' before you split). Prefer parsing the raw query (getRawQuery) or, better, construct URIBuilder directly from the original URI/string so it handles query parsing/encoding correctly.
Suggested change
| URIBuilder uriBuilder = new URIBuilder() | |
| .setScheme(originalUri.getScheme()) | |
| .setHost(originalUri.getHost()) | |
| .setPort(originalUri.getPort()) | |
| .setPath(originalUri.getPath()); | |
| // Parse and add query parameters - URIBuilder will encode them | |
| if (originalUri.getQuery() != null) { | |
| String[] pairs = originalUri.getQuery().split("&"); | |
| for (String pair : pairs) { | |
| String[] keyValue = pair.split("=", 2); | |
| if (keyValue.length == 2) { | |
| uriBuilder.addParameter(keyValue[0], keyValue[1]); | |
| } else { | |
| uriBuilder.addParameter(keyValue[0], ""); | |
| } | |
| } | |
| } | |
| // Let URIBuilder parse the full original URI, including query parameters, | |
| // to avoid manual splitting of the decoded query string. | |
| URIBuilder uriBuilder = new URIBuilder(originalUri); |
Comment on lines
+229
to
+247
| URIBuilder uriBuilder = new URIBuilder() | ||
| .setScheme(originalUri.getScheme()) | ||
| .setHost(originalUri.getHost()) | ||
| .setPort(originalUri.getPort()) | ||
| .setPath(originalUri.getPath()); | ||
|
|
||
| // Parse and add query parameters - URIBuilder will encode them | ||
| if (originalUri.getQuery() != null) { | ||
| String[] pairs = originalUri.getQuery().split("&"); | ||
| for (String pair : pairs) { | ||
| String[] keyValue = pair.split("=", 2); | ||
| if (keyValue.length == 2) { | ||
| uriBuilder.addParameter(keyValue[0], keyValue[1]); | ||
| } else { | ||
| uriBuilder.addParameter(keyValue[0], ""); | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This rebuilds the URI from scheme/host/port/path only, which drops other components like fragment (#...), user-info, and any original path encoding (getPath() is decoded). If the report URL can contain these, the returned URL will be altered. Using URIBuilder(originalUri) (or URIBuilder(reportUrl)) and only adjusting encoding as needed will preserve all components.
Suggested change
| URIBuilder uriBuilder = new URIBuilder() | |
| .setScheme(originalUri.getScheme()) | |
| .setHost(originalUri.getHost()) | |
| .setPort(originalUri.getPort()) | |
| .setPath(originalUri.getPath()); | |
| // Parse and add query parameters - URIBuilder will encode them | |
| if (originalUri.getQuery() != null) { | |
| String[] pairs = originalUri.getQuery().split("&"); | |
| for (String pair : pairs) { | |
| String[] keyValue = pair.split("=", 2); | |
| if (keyValue.length == 2) { | |
| uriBuilder.addParameter(keyValue[0], keyValue[1]); | |
| } else { | |
| uriBuilder.addParameter(keyValue[0], ""); | |
| } | |
| } | |
| } | |
| URIBuilder uriBuilder = new URIBuilder(originalUri); |
reportium-java/src/main/java/com/perfecto/reportium/client/PerfectoReportiumClient.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.